Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perple_X ] update to version 7.1.9 #9719

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brenhinkeller
Copy link

CC @boriskaus @jadconnolly does this look correct?

@boriskaus
Copy link
Contributor

looks like you forgot to compile MC_fit

[14:19:35]  ---> for file in ${FilesArray[*]}
[14:19:35]  ---> install -Dvm 755 $file${exeext} "${bindir}/$file${exeext}"
[14:19:35] install: can't stat 'MC_fit': No such file or directory

@brenhinkeller
Copy link
Author

Oh hmm, I was just trying to copy the previous PRs that seem to just bump the version and sha.. did things move internally within the perplex repo or something?

@jadconnolly
Copy link
Contributor

jadconnolly commented Oct 31, 2024 via email

@boriskaus
Copy link
Contributor

  1. am i right that you're gonna leave me to push releases to the julia package manager? that's ok by me and given your previous help i can probably manage, but of course it's fine by me if you intend to continue to do it.

I would actually prefer if you maintain this, as I'm involved in many other open-source projects and can't always keep up with this. Ofcourse, if @brenhinkeller is happy to help that is fine as well.

  1. i made a new release (7.1.9) mainly because i had screwed up the LINUX_makefile so that the precompiled "release asset" was no longer statically linked. because the other corrections were minor, and because i thought the push to the package manager was not automatic, i didn't bother with trying to make the push myself.

I guess the issue is that as soon as you make a new release of Perple_X, some users would like to incorporate this immediately and compile new binaries. As long make sure that make all works, it should be fine.

  1. MC_fit is in development and not documented, though it does do some useful things (fitting data, thermobarometry). Given the lack of documentation I don't think it's all that useful to push it to the package manager, but if its presence somewhere (the makefile?) makes that automatic or is causing other problems then tell me and i'll modify whatever needs to be modified. Since I use MC_fit it's an easier for me if i keep it as part of Perple_X, so that's my preference.

In the current build_tarballs.jl file, MC_fit is listed as a file to be compiled. If you just take this out for now, and also comment the library, it won't be included in the BinaryBuilder version.

@jadconnolly
Copy link
Contributor

jadconnolly commented Oct 31, 2024 via email

@brenhinkeller
Copy link
Author

Ah I just have a grad student who's been having issues with gridding on 7.1.8 and was hoping that 7.1.9 would fix that, so I thought I'd try to get the JLL build started -- I've never submitted a yggdrasil PR before though so have even less idea what I'm doing probably!

@jadconnolly
Copy link
Contributor

jadconnolly commented Oct 31, 2024 via email

@jadconnolly
Copy link
Contributor

jadconnolly commented Oct 31, 2024 via email

@jadconnolly
Copy link
Contributor

jadconnolly commented Oct 31, 2024 via email

@brenhinkeller
Copy link
Author

Looks like we're in business! Thanks so much Jamie!

@jadconnolly
Copy link
Contributor

jadconnolly commented Oct 31, 2024 via email

@brenhinkeller brenhinkeller changed the title Update for Perple_X v7.1.9 [Perple_X ] update to version 7.1.9 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants